[CatalogPromotion] Apply catalog promotions for product created in catalog promotions scope #13538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
Jan 26, 2022
GSadee
force-pushed
the
apply-cp-when-create-product
branch
3 times, most recently
from
5179dd3
to
5594413
Compare
GSadee
changed the title
AdamKasp
suggested changes
Jan 31, 2022
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductVariantsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Listener/ProductVariantCreatedListener.php
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
Jan 31, 2022
GSadee
force-pushed
the
apply-cp-when-create-product
branch
from
6ee7620
to
0f27fa5
Compare
GSadee
force-pushed
the
apply-cp-when-create-product
branch
from
0f27fa5
to
e49e3fc
Compare
SirDomin
approved these changes
Jan 31, 2022
lchrusciel
approved these changes
Jan 31, 2022
| @@ -250,6 +264,7 @@ protected function getDefinedElements(): array | |||
| 'language_tab' => '[data-locale="%locale%"] .title', | |||
| 'locale_tab' => '#attributesContainer .menu [data-tab="%localeCode%"]', | |||
| 'main_taxon' => '#sylius_product_mainTaxon', | |||
| 'product_taxons' => '#sylius_product_productTaxons', | |||
There was a problem hiding this comment.
Can we use test attribute here?
There was a problem hiding this comment.
IIRC we are using test attribute only in shop
| And I am logged in as an administrator | ||
|
|
||
| @ui @javascript @no-api | ||
| Scenario: Applying catalog promotion on newly created simple product |
There was a problem hiding this comment.
I'm wondering if we should cover product creation without any variant case as well
|
Thank you, @ernestWarwas! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New products should apply for catalog promotion if falls in catalog promotion scope (eg. when creating a new product in taxon „Clothes” which applies for catalog promotion)