[CatalogPromotion] Process all catalog promotions when catalog promotion is created #13550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
reviewed
Jan 27, 2022
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Jan 27, 2022
src/Sylius/Bundle/CoreBundle/Listener/CatalogPromotionCreatedListener.php
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Jan 27, 2022
src/Sylius/Bundle/CoreBundle/Listener/CatalogPromotionCreatedListener.php
Outdated
Show resolved
Hide resolved
AdamKasp
approved these changes
Jan 27, 2022
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
Comment on lines
138
to
146
| When I want to create a new catalog promotion | ||
| And I specify its code as "winter_sale" | ||
| And I name it "Winter sale" | ||
| And I specify its label as "Winter sale" in "English (United States)" | ||
| And I describe it as "This promotion gives a 50% discount on all products" in "English (United States)" | ||
| And I add scope that applies on variants "PHP T-Shirt" variant and "Kotlin T-Shirt" variant | ||
| And I add action that gives "50%" percentage discount | ||
| And I make it start yesterday and ends tomorrow | ||
| And I make it available in channel "United States" |
There was a problem hiding this comment.
IMO we should merge it into single step.
SirDomin
changed the title
GSadee
approved these changes
Jan 27, 2022
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature
Show resolved
Hide resolved
SirDomin
force-pushed
the
create-catalog-promotion-with-priorities
branch
from
0023d15
to
af319f3
Compare
Zales0123
approved these changes
Jan 27, 2022
Comment on lines
+140
to
+149
| And I specify its code as "winter_sale" | ||
| And I name it "Winter sale" | ||
| And I specify its label as "Winter sale" in "English (United States)" | ||
| And I describe it as "This promotion gives a 5$ discount on all products" in "English (United States)" | ||
| And I set its priority to 150 | ||
| And I add scope that applies on variants "PHP T-Shirt" variant and "Kotlin T-Shirt" variant | ||
| And I add action that gives "$5" of fixed discount in the "United States" channel | ||
| And I make it start yesterday and ends tomorrow | ||
| And I make it available in channel "United States" | ||
| And I add it |
There was a problem hiding this comment.
We should definitely think about some more complex steps for promotion creation to avoid a long wall of text each time we want to create a catalog promotion 💃 Something like:
When I create a "Winter sale" catalog promotion with priority 150 that discounting "PHP T-Shirt" variant by "$5" in "United States" channel
? Of course it would need to resolve some default values, but may be worth to be considered 🖖
|
Thanks, @SirDomin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Feb 2, 2022
…tion (TheMilek) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | #13550 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> We should also have scenario for creating an exclusive catalog promotion to control it's behaviour with priorities Commits ------- aa9ca37 [Behat] scenario for creating an exclusive catalog promotion 43e8073 Merge branch '1.11' of github.com:Sylius/Sylius into behat-test-with-exclusive-promotion 8663504 [Behat] outdated class correction 583ca24 [API] catalog promotion request content correction 3bf52b5 [Behat] refactoring implementation of the steps to use a private method instead
GSadee
added a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Feb 2, 2022
…tion (TheMilek) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | Sylius/Sylius#13550 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> We should also have scenario for creating an exclusive catalog promotion to control it's behaviour with priorities Commits ------- aa9ca377d0229898b0ad152eec4dbed4916ca5d3 [Behat] scenario for creating an exclusive catalog promotion 43e8073dd64ed65ee94ceea6620cb6a9f382d250 Merge branch '1.11' of github.com:Sylius/Sylius into behat-test-with-exclusive-promotion 8663504e90d7418fc69d6f7dc8887023e1d40c88 [Behat] outdated class correction 583ca248d2497a64079690ffb8d91684cc650024 [API] catalog promotion request content correction 3bf52b505e5c0391312412e523d310a280edcb76 [Behat] refactoring implementation of the steps to use a private method instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Handling CatalogPromotionCreated we weren't processing all available catalog promotions, now it takes all into account.