Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the documentation (1.10) #13552

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Jan 26, 2022

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #13523
License MIT

As mentioned in here: #13523 (comment) the documentation should have been fixed for 1.10 as well. So here is the merge request.

This might make trouble when trying to upmerge though.

@mamazu mamazu requested a review from a team as a code owner January 26, 2022 22:51
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jan 26, 2022
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Max, thanks a lot for your fix! :)

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Jan 27, 2022
@lchrusciel lchrusciel merged commit 3449cad into Sylius:1.10 Jan 27, 2022
@lchrusciel
Copy link
Member

Thank you, @mamazu! 🎉

@mamazu mamazu deleted the better-documentation branch January 27, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants