Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixtures] USA deleted from the World zone #13553

Merged
merged 1 commit into from Jan 27, 2022

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 26, 2022

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

USA being a part of 2 zones at once was misleading with the concept of actual work predicted for zones and was causing some problems when calculating taxes for this country in case this 2 zones had different taxes.

@TheMilek TheMilek requested a review from a team as a code owner January 26, 2022 23:10
@TheMilek TheMilek force-pushed the fixtures-for-zones-with-taxes branch from 422c9fc to c6a9298 Compare January 27, 2022 08:36
@TheMilek TheMilek requested a review from GSadee January 27, 2022 08:36
@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Jan 27, 2022
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fixtures-for-zones-with-taxes" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel changed the base branch from 1.11 to 1.10 January 27, 2022 09:03
@TheMilek TheMilek force-pushed the fixtures-for-zones-with-taxes branch from 38fffc6 to cdaa1b8 Compare January 27, 2022 11:39
@lchrusciel lchrusciel merged commit b4a573b into Sylius:1.10 Jan 27, 2022
@lchrusciel
Copy link
Member

Thanks, Kamil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants