Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Scenario for creating an exclusive catalog promotion #13556

Merged
merged 5 commits into from
Feb 2, 2022
Merged

[Behat] Scenario for creating an exclusive catalog promotion #13556

merged 5 commits into from
Feb 2, 2022

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 27, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets #13550
License MIT

We should also have scenario for creating an exclusive catalog promotion to control it's behaviour with priorities

@TheMilek TheMilek requested a review from a team as a code owner January 27, 2022 20:38
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch 3 times, most recently from 06f7de2 to 6286fef Compare January 28, 2022 13:32
@Zales0123 Zales0123 added Behat Issues and PRs aimed at improving Behat usage. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Jan 28, 2022
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch from 6286fef to d006219 Compare January 31, 2022 12:13
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jan 31, 2022
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch 2 times, most recently from b58ad00 to b12fd45 Compare January 31, 2022 12:19
@TheMilek TheMilek requested a review from GSadee January 31, 2022 12:21
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch 2 times, most recently from 2b763c0 to e2a3209 Compare January 31, 2022 12:50
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch from e2a3209 to aa9ca37 Compare January 31, 2022 12:58
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch 2 times, most recently from 72e689a to bcec6c7 Compare February 1, 2022 09:22
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch 3 times, most recently from bc0aa73 to 874292a Compare February 1, 2022 10:08
GSadee
GSadee reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing scenario for adding an exclusive promotion (with higher or lower priority), when there is already an exclusive one applied in the catalog

features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature Outdated Show resolved Hide resolved
@TheMilek TheMilek force-pushed the behat-test-with-exclusive-promotion branch from 874292a to 3bf52b5 Compare February 1, 2022 16:10
@TheMilek TheMilek requested a review from GSadee February 1, 2022 16:16
@GSadee GSadee merged commit 719895d into Sylius:1.11 Feb 2, 2022
@GSadee
Copy link
Member

GSadee commented Feb 2, 2022

Thanks, Kamil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@SirDomin SirDomin SirDomin left review comments

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheMilek @GSadee @Zales0123 @lchrusciel @SirDomin @AdamKasp