PHP 8.0 syntax in bundles (without CoreBundle and ApiBundle) #13562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Jan 28, 2022
Zales0123
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | continuation of #13502 |
| License | MIT |
Zales0123
added
Enhancement
Zales0123
commented
Jan 28, 2022
| @@ -47,7 +41,7 @@ public function validate($value, Constraint $constraint): void | |||
| $propertyPath = $this->context->getPropertyPath(); | |||
|
|
|||
| foreach (iterator_to_array($this->context->getViolations()) as $violation) { | |||
| if (0 === strpos($violation->getPropertyPath(), $propertyPath)) { | |||
| if (str_starts_with($violation->getPropertyPath(), $propertyPath)) { | |||
There was a problem hiding this comment.
OH MY GOD it feels so good ❤️
There was a problem hiding this comment.
Yes, I agree, this is a great one.
Zales0123
force-pushed
the
php8-syntax-bundles
branch
from
242fe71
to
f08ca1c
Compare
Zales0123
force-pushed
the
php8-syntax-bundles
branch
from
f08ca1c
to
2def894
Compare
probot-autolabeler
bot
added
the
Maintenance
AdamKasp
approved these changes
Jan 31, 2022
loic425
reviewed
Jan 31, 2022
src/Sylius/Bundle/AdminBundle/Controller/Dashboard/StatisticsController.php
Outdated
Show resolved
Hide resolved
loic425
reviewed
Jan 31, 2022
src/Sylius/Bundle/AdminBundle/Controller/DashboardController.php
Outdated
Show resolved
Hide resolved
This was referenced Jan 31, 2022
lchrusciel
added a commit
that referenced
this pull request
Feb 3, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | extracted from #13562 for better readability | License | MIT Commits ------- b21b626 PHP 8 syntax in bundles vol.3 8b42dbd CS fixes
lchrusciel
reviewed
Feb 3, 2022
src/Sylius/Bundle/AdminBundle/Controller/Dashboard/StatisticsController.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Controller/CustomerStatisticsController.php
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
php8-syntax-bundles
branch
2 times, most recently
from
8437ecf
to
c4e7e4b
Compare
lchrusciel
approved these changes
Feb 3, 2022
| UserProviderInterface $userProvider, | ||
| private UserImpersonatorInterface $impersonator, | ||
| private AuthorizationCheckerInterface $authorizationChecker, | ||
| private UserProviderInterface $userProvider, | ||
| ?RouterInterface $router, |
There was a problem hiding this comment.
Suggested change
| ?RouterInterface $router, | |
| private ?RouterInterface $router, |
There was a problem hiding this comment.
But to be honest, we should rework this argument, to be able to replace logic with the new one
There was a problem hiding this comment.
Interesting idea, we can elaborate over it in the separate PR 🖖
Comment on lines
29
to
30
| private ?RouterInterface $router; | ||
|
|
There was a problem hiding this comment.
Suggested change
| private ?RouterInterface $router; |
|
|
||
| $this->impersonator = $impersonator; | ||
| $this->authorizationChecker = $authorizationChecker; | ||
| $this->userProvider = $userProvider; | ||
| $this->router = $router; |
There was a problem hiding this comment.
Suggested change
| $this->router = $router; |
src/Sylius/Bundle/LocaleBundle/Templating/Helper/LocaleHelper.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/LocaleBundle/Templating/Helper/LocaleHelper.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/LocaleBundle/Templating/Helper/LocaleHelper.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Controller/SecurityWidgetController.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Controller/SecurityWidgetController.php
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
php8-syntax-bundles
branch
from
c4e7e4b
to
9e395ac
Compare
Zales0123
force-pushed
the
php8-syntax-bundles
branch
from
9e395ac
to
ced91b9
Compare
lchrusciel
approved these changes
Feb 4, 2022
|
Thank you, Mateusz! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Feb 4, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | extracted from #13562 for better readability | License | MIT Commits ------- 128117c PHP 8 syntax in bundles vol.2 e52f894 Line length fixes 160361f Small CS fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.