[Catalog Promotion] Catalog promotion states refactor #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestWarwas
changed the title
ernestWarwas
changed the title
lchrusciel
reviewed
Jan 31, 2022
...motion/applying_catalog_promotions/applying_catalog_promotions_with_different_states.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionEligibilityChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionEligibilityChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Listener/CatalogPromotionUpdatedListener.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionStateProcessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionStateProcessorSpec.php
Show resolved
Hide resolved
AdamKasp
reviewed
Jan 31, 2022
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionEligibilityChecker.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionStateProcessor.php
Outdated
Show resolved
Hide resolved
Zales0123
added
the
Enhancement
GSadee
reviewed
Feb 1, 2022
src/Sylius/Bundle/CoreBundle/spec/Checker/CatalogPromotionEligibilityCheckerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Checker/CatalogPromotionEligibilityCheckerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionStateProcessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionStateProcessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Doctrine/ORM/CatalogPromotionRepository.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Doctrine/ORM/CatalogPromotionRepository.php
Outdated
Show resolved
Hide resolved
ernestWarwas
changed the title
AdamKasp
reviewed
Feb 1, 2022
src/Sylius/Bundle/CoreBundle/spec/Checker/CatalogPromotionEligibilityCheckerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Checker/CatalogPromotionEligibilityCheckerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionStateProcessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionStateProcessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Provider/EligibleCatalogPromotionProvider.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Feb 2, 2022
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionEligibilityChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionEligibilityCheckerInterface.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Listener/CatalogPromotionEndedListener.php
Outdated
Show resolved
Hide resolved
ernestWarwas
force-pushed
the
catalog-promotion-states-refactor
branch
2 times, most recently
from
7cb3768
to
29f8851
Compare
GSadee
approved these changes
Feb 2, 2022
src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/spec/Criteria/DateRangeSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/spec/Criteria/EnabledSpec.php
Outdated
Show resolved
Hide resolved
ernestWarwas
force-pushed
the
catalog-promotion-states-refactor
branch
2 times, most recently
from
c643c45
to
ef2f806
Compare
CatalogPromotionStateProcessor added refactor and spec removed unused
…logPromotionApplicator
review fixes and added provider to find eligible cp missing license block review fixes
added new listener CatalogPromotionStateChangedListener and review fixes eligibility provider namespaces fix added verify method to CriteriaInterface small fixes in naming clean up
ernestWarwas
force-pushed
the
catalog-promotion-states-refactor
branch
from
b84e64b
to
90cc645
Compare
lchrusciel
reviewed
Feb 3, 2022
src/Sylius/Bundle/CoreBundle/spec/Checker/CatalogPromotionEligibilityCheckerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/spec/Criteria/EnabledSpec.php
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Feb 3, 2022
|
Thanks, @ernestWarwas! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After change to process per variant in catalog promotions, we want to change place of changing catalog promotion state. In this PR I added a new Listener which is listening for Created, Updated and Ended Catalog Promotion events and changing it state if eligible because this operation from an architectural point of view is not connected with variant processing.