Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog Promotion] add update variant event to messenger routing #13578

Merged
merged 1 commit into from Feb 2, 2022
Merged

[Catalog Promotion] add update variant event to messenger routing #13578

merged 1 commit into from Feb 2, 2022

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Feb 1, 2022

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner February 1, 2022 14:20
@AdamKasp AdamKasp force-pushed the add-update-variant-event-to-messanger-routing branch from 321efda to 0c75529 Compare February 1, 2022 14:26
@AdamKasp AdamKasp changed the base branch from master to 1.11 February 1, 2022 14:38
@AdamKasp AdamKasp force-pushed the add-update-variant-event-to-messanger-routing branch from 0c75529 to a5a6382 Compare February 1, 2022 14:40
@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 2, 2022
@lchrusciel lchrusciel mentioned this pull request Feb 2, 2022
Merged
@lchrusciel lchrusciel merged commit 1ceba26 into Sylius:1.11 Feb 2, 2022
@lchrusciel
Copy link
Member

Thanks, Adam! 🥇

GSadee added a commit that referenced this pull request Feb 3, 2022
@GSadee
refactor #13579 [Catalog Promotion] Move catalog promotion processing…
0dbb05b 
… after the fixture execution (lchrusciel)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

Previous:
~With clearing entity manger we don't need to trace that many objects in UnitOfWork, therefore we are not calculating that much changes and we save ton of memory.~

~Ref. https://blackfire.io/profiles/compare/7c9cb9fd-c43f-4420-8e0a-0af2a7b4b000/graph~

Now:
Just a refactor of CP fixtures. The EntityManager will be cleared with https://github.com/symfony/doctrine-bridge/blob/5.4/Messenger/DoctrineClearEntityManagerWorkerSubscriber.php just by the fact, that it will be processed asynced. Which will be done in #13578. 

#13578 vs previous implementation -https://blackfire.io/profiles/compare/f560f723-f970-41b3-ac1a-7fe3a8858d77/graph

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

ee3a2da [Catalog Promotion] Move catalog promotion processing after the fixture execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamKasp @lchrusciel @Zales0123