[Catalog Promotion][Docs] update CP scopes docs #13591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Feb 3, 2022
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| License | MIT |
AdamKasp
added
the
Documentation
GSadee
approved these changes
Feb 3, 2022
| arguments: | ||
| - '@sylius.repository.product_variant' | ||
| tags: | ||
| - { name: 'sylius.catalog_promotion.variants_provider', type: 'by_phrase' } | ||
| - { name: 'sylius.catalog_promotion.variant_checker', type: 'for_phrase' } |
There was a problem hiding this comment.
Suggested change
| - { name: 'sylius.catalog_promotion.variant_checker', type: 'for_phrase' } | |
| - { name: 'sylius.catalog_promotion.variant_checker', type: 'by_phrase' } |
| { | ||
| public const TYPE = 'by_phrase'; | ||
| public const TYPE = 'for_phrase'; |
There was a problem hiding this comment.
Suggested change
| public const TYPE = 'for_phrase'; | |
| public const TYPE = 'by_phrase'; |
|
Thank you, Adam! 🎉 |
lchrusciel
reviewed
Feb 3, 2022
Comment on lines
+62
to
+66
| return in_array( | ||
| $productVariant, | ||
| $this->productVariantRepository->findByPhrase($configuration['phrase'], 'en_US'), | ||
| true | ||
| ); |
There was a problem hiding this comment.
It will do almost similar thing(we will not check by code and english locale is not guaranteed), but lets not encourage to load additional data from db at this stage
Suggested change
| return in_array( | |
| $productVariant, | |
| $this->productVariantRepository->findByPhrase($configuration['phrase'], 'en_US'), | |
| true | |
| ); | |
| return str_contains($productVariant->getName(), $configuration['phrase']); |
AdamKasp
added a commit
that referenced
this pull request
Feb 4, 2022
… (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | resolves comments from #13591 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 4e15ce3 [Cookbook] Minor fixes in custom catalog promotion scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.