[Catalog Promotion][Test] Assert proper batch size configuration #13594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
added
DX
lchrusciel
force-pushed
the
changing-batch-size-to-be-part-of-catalog-promo
branch
4 times, most recently
from
662d4b7
to
c854c9d
Compare
Rafikooo
approved these changes
Feb 3, 2022
lchrusciel
force-pushed
the
changing-batch-size-to-be-part-of-catalog-promo
branch
from
c854c9d
to
2a0d4f3
Compare
Zales0123
reviewed
Feb 4, 2022
Comment on lines
+60
to
+62
| ->ifTrue(function (int $batchSize): bool { | ||
| return $batchSize <= 0; | ||
| }) |
There was a problem hiding this comment.
->ifTrue(fn(int $batchSize): bool => $batchSize <= 0)? 😄
|
|
||
| /** | ||
| * @test | ||
| */ |
There was a problem hiding this comment.
What about oneliner /** @test */?
|
Thank you, Łukasz! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Feb 4, 2022
…s0123) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Applying comments from #13594, I've also enabled some tests that were not run at all 💃 Commits ------- 19ba403 Arrow function in configuration 82e4b96 Enable tests that were not tagged as tests
lchrusciel
deleted the
changing-batch-size-to-be-part-of-catalog-promo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional validation in configuration tree with related tests. Based on #13587