Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Configuration style and tests improvements #13597

Merged
merged 2 commits into from Feb 4, 2022
Merged

Core Configuration style and tests improvements #13597

merged 2 commits into from Feb 4, 2022

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Applying comments from #13594, I've also enabled some tests that were not run at all 馃拑

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 4, 2022
@Zales0123 Zales0123 requested a review from a team as a code owner February 4, 2022 08:09
@lchrusciel lchrusciel merged commit 37dab55 into Sylius:1.11 Feb 4, 2022
@lchrusciel
Copy link
Member

Thank you, Mateusz! 馃

@Zales0123 Zales0123 deleted the core-configuration-style-improvements branch February 4, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@loic425 loic425 loic425 approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zales0123 @lchrusciel @loic425