Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Gaufrette FilesystemInterface instead of a concrete implementation #13601

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 4, 2022

Q A
Branch? 1.11
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

The image uploader has a dependency to a concrete class instead of the interface. This widens the parameter type to allow the interface.

@mbabker mbabker requested a review from a team as a code owner February 4, 2022 15:48
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 20, 2022
@GSadee GSadee changed the base branch from 1.11 to 1.10 April 20, 2022 06:45
@GSadee
Copy link
Member

GSadee commented Apr 20, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee closed this Apr 20, 2022
@GSadee GSadee reopened this Apr 20, 2022
@GSadee GSadee merged commit b1f651a into Sylius:1.10 Apr 20, 2022
@GSadee
Copy link
Member

GSadee commented Apr 20, 2022

Thanks, Michael! 🥇

@mbabker mbabker deleted the patch-1 branch April 20, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants