[CatalogPromotion][UI][Shop] Fixed label displaying after option change #13604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
commented
Feb 10, 2022
| @@ -124,7 +123,7 @@ public function getCatalogPromotionName(): string | |||
|
|
|||
| public function hasCatalogPromotionApplied(string $name): bool | |||
| { | |||
| $catalogPromotions = $this->getDocument()->findAll('css', '.promotion_label'); | |||
| $catalogPromotions = $this->getDocument()->findAll('css', '.column .promotion_label'); | |||
There was a problem hiding this comment.
I've added that cascade class, to distinguish the add to cart section with Lastest products, which was giving a false positive with a visible label
AdamKasp
approved these changes
Feb 10, 2022
src/Sylius/Behat/Context/Transform/ProductOptionValueContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Transform/ProductOptionValueContext.php
Outdated
Show resolved
Hide resolved
lchrusciel
approved these changes
Feb 10, 2022
src/Sylius/Behat/Context/Transform/ProductOptionValueContext.php
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Feb 10, 2022
Comment on lines
+34
to
+36
| Assert::eq( | ||
| count($productOptionValues), | ||
| 1, |
There was a problem hiding this comment.
Suggested change
| Assert::eq( | |
| count($productOptionValues), | |
| 1, | |
| Assert::count( | |
| $productOptionValues, | |
| 1, |
| Assert::eq( | ||
| count($productOptionValues), | ||
| 1, | ||
| sprintf('%d product option values has been found with name "%s" but should be only one.', count($productOptionValues), $code) |
There was a problem hiding this comment.
Suggested change
| sprintf('%d product option values has been found with name "%s" but should be only one.', count($productOptionValues), $code) | |
| sprintf('%d product option values have been found with name "%s" but should be only one.', count($productOptionValues), $code) |
| @@ -410,6 +410,14 @@ public function iShouldSeeProductNotDiscountedOnTheList(string $productName): vo | |||
| Assert::null($originalPrice); | |||
| } | |||
|
|
|||
| /** | |||
| * @Then /^I should see this product is not discounted$/ | |||
There was a problem hiding this comment.
Suggested change
| * @Then /^I should see this product is not discounted$/ | |
| * @Then I should see this product is not discounted |
|
Thank you, Rafał! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying a proper catalog promotion labels while switching product's variants