Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value #13607

Merged
merged 2 commits into from Feb 10, 2022
Merged

[Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value #13607

merged 2 commits into from Feb 10, 2022

Conversation

ernestWarwas
Copy link
Contributor

@ernestWarwas ernestWarwas commented Feb 7, 2022 •
edited

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no

When trying to edit the percentage discount value and save it with an empty amount there was a 500 error. This PR provides only a workaround for this problem.

image

image

@ernestWarwas ernestWarwas requested a review from a team as a code owner February 7, 2022 11:48
@ernestWarwas ernestWarwas changed the title [Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value [WIP][Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value Feb 7, 2022
@ernestWarwas ernestWarwas changed the title [WIP][Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value [Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value Feb 7, 2022
@ernestWarwas ernestWarwas added the Bug Confirmed bugs or bugfixes. label Feb 7, 2022
@ernestWarwas ernestWarwas changed the base branch from master to 1.11 February 8, 2022 12:47
@ernestWarwas ernestWarwas changed the title [Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value [WIP][Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value Feb 9, 2022
@Zales0123 Zales0123 force-pushed the percentage-discount-validation branch from 5a44e16 to 03b9fd3 Compare February 10, 2022 17:03
@Zales0123 Zales0123 changed the title [WIP][Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value [Catalog Promotion][UI] Fixed error when trying to save catalog promotion with empty percentage discount value Feb 10, 2022
Zales0123
Zales0123 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a workaround/hotfix and we need a deeper look into the problem... but it at least solves an issue and still can be fixed after the stable release 🖖

@Zales0123 Zales0123 merged commit 0f2bcce into Sylius:1.11 Feb 10, 2022
@Zales0123
Copy link
Member

Thanks, @ernestWarwas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@AdamKasp AdamKasp AdamKasp left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ernestWarwas @Zales0123 @lchrusciel @AdamKasp