Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog Promotion] Improve fixtures #13608

Merged
merged 2 commits into from Feb 9, 2022
Merged

[Catalog Promotion] Improve fixtures #13608

merged 2 commits into from Feb 9, 2022

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Feb 7, 2022

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
License MIT

@AdamKasp AdamKasp added the DX Issues and PRs aimed at improving Developer eXperience. label Feb 7, 2022
@AdamKasp AdamKasp requested a review from a team as a code owner February 7, 2022 13:59
@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch from 26ed51a to ba96e5b Compare February 7, 2022 14:22
lchrusciel
lchrusciel approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want functional tests for fixtures? For example executing example factories and checking if returned objects is properly created /cc @Sylius/core-team

@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch from ba96e5b to 6feaea0 Compare February 7, 2022 15:05
@AdamKasp AdamKasp changed the base branch from master to 1.11 February 7, 2022 15:07
@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch from 6feaea0 to 18b0b24 Compare February 7, 2022 15:10
@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch 4 times, most recently from 8ff83d2 to 2a31704 Compare February 8, 2022 12:46
@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch from 2a31704 to 0459d9e Compare February 9, 2022 09:06
@AdamKasp AdamKasp force-pushed the improve-catalog-promotion-fixtures branch from 0459d9e to ebb6fb4 Compare February 9, 2022 09:07
@Zales0123 Zales0123 merged commit bf21ba1 into Sylius:1.11 Feb 9, 2022
@Zales0123
Copy link
Member

Thanks, Adam! 🎉

@AdamKasp AdamKasp deleted the improve-catalog-promotion-fixtures branch February 9, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@SirDomin SirDomin SirDomin approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AdamKasp @Zales0123 @GSadee @lchrusciel @SirDomin