[Behat][API] Fixed adding simple product scenarios #13616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestWarwas
changed the title
ernestWarwas
changed the title
AdamKasp
suggested changes
Feb 8, 2022
features/product/managing_products/adding_product_with_associations.feature
Outdated
Show resolved
Hide resolved
features/product/managing_products/adding_product_with_associations.feature
Outdated
Show resolved
Hide resolved
ernestWarwas
force-pushed
the
api-fix-adding-simple-products
branch
from
509dc14
to
5b920a4
Compare
AdamKasp
reviewed
Feb 9, 2022
ernestWarwas
force-pushed
the
api-fix-adding-simple-products
branch
from
43c0447
to
5b920a4
Compare
lchrusciel
reviewed
Feb 9, 2022
features/cart/shopping_cart/adding_product_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
features/cart/shopping_cart/adding_product_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
features/cart/shopping_cart/adding_product_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
[Behat] add no-api tag to simple product create tests [Behat] add no-api tag to simple product create tests [Behat] review fixes [Behat] added/removed no-api tags from some scenarios [Behat] added/removed no-api tags from some scenarios [Behat] added/removed no-api tags from some scenarios [Behat] creating product with an autogenerated slug now creates configurable product instead of simple [Behat] suggested changes
ernestWarwas
force-pushed
the
api-fix-adding-simple-products
branch
from
f1961ad
to
568bb0a
Compare
lchrusciel
approved these changes
Feb 9, 2022
|
Thanks, @ernestWarwas! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Feb 9, 2022
…ation in api tests (ernestWarwas) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Related tickets | second part of #13616 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 1d3f168 [Behat] add no-api tag to simple product create tests part 2 35f4a6a [Behat] completly remove simple product concept from api tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple product concept does not exists in API so we need to tag all behat scenarios creating simple product as no-api