Update ResourceBundle and GridBundle #13622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Enhancement
Roshyo
approved these changes
Feb 10, 2022
Zales0123
force-pushed
the
check-out-sylius-with-new-resource-and-grid
branch
from
03d265b
to
1f5351c
Compare
Zales0123
force-pushed
the
check-out-sylius-with-new-resource-and-grid
branch
from
1f5351c
to
bb10497
Compare
Zales0123
force-pushed
the
check-out-sylius-with-new-resource-and-grid
branch
from
bb10497
to
4a340cd
Compare
Zales0123
force-pushed
the
check-out-sylius-with-new-resource-and-grid
branch
from
4a340cd
to
e58150b
Compare
Zales0123
changed the title
lchrusciel
approved these changes
May 4, 2022
|
Thanks, Mateusz! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to see does the current Sylius 1.11 works with upcoming SyliusResourceBundle and SyliusGridBundle versions 馃枛 Also would tell us what we need to do more (either in bundles or Sylius itself). Would be great to have this support in 1.11 馃殌UPDATE: We didn't manage to put it in 1.11 馃拑 But 1.12 is still great. I thought about not bumping the required versions, but that would need us to create another level of build matrix and would eventually result in a workflow nightmare. I believe it's a fair assumption we would like to go with new, modern grid and resource versions 馃枛