[Core] Reorganize namespaces of services related with catalog promotions #13623
Conversation
GSadee
commented
Feb 9, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
GSadee
force-pushed
the
core-catalog-promotions-reorganization
branch
3 times, most recently
from
16d2b8e
to
7ac5440
Compare
GSadee
force-pushed
the
core-catalog-promotions-reorganization
branch
3 times, most recently
from
3f3c5d5
to
1a98be5
Compare
GSadee
force-pushed
the
core-catalog-promotions-reorganization
branch
from
1a98be5
to
7cf8b7b
Compare
| @@ -11,9 +11,9 @@ | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| namespace Sylius\Bundle\CoreBundle\Validator\Constraints; | |||
| namespace Sylius\Bundle\CoreBundle\CatalogPromotion\Validator\Constraints; | |||
There was a problem hiding this comment.
I wonder, can we move it to PromotionBundle? It's almost identical, we could maybe even unify these services and register them under 2 different names for 2 different tags
There was a problem hiding this comment.
It also somehow completes this PR
There was a problem hiding this comment.
It's almost identical to.. which service? I agree that the interface should be moved to the PromotionBundle, but I wonder if this validator also as it is connected with entities not related with promotions 🤔 However, even if this one could be moved to the bundle, what about the constraint, moving it there doesn't make sense (because of validation messages) and separating them in 2 different bundles also? I would be for considering it in your separate PR as this one only changes the namespaces in CoreBundle
There was a problem hiding this comment.
Almost identical to CatalogPromotionActionValidator, sorry, I've lost the part of the sentence 🖖 I would probably be for moving all of these into the PromotionBundle, as this functionality is not related to products or variants at all (specific validators are) and drop the validation messages in constraint and just use translation keys in the validators (we're anyway doing this e.g. here). But I agree it can be done in the separate PR 🚀
|
Thank you, Grzegorz! 🎉 |
…t to PromotionBundle (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13623 (comment) | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 60496db [CatalogPromotion] Move scope validator and constraint to PromotionBundle
