Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotions] Refactor processing catalog promotions states to use commands #13624

Merged
merged 1 commit into from Feb 9, 2022
Merged

[CatalogPromotions] Refactor processing catalog promotions states to use commands #13624

merged 1 commit into from Feb 9, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Feb 9, 2022

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Feb 9, 2022
@GSadee GSadee requested a review from a team as a code owner February 9, 2022 13:49
@GSadee GSadee force-pushed the catalog-promotions-states-fixtures branch from ebd8fe1 to 7249a33 Compare February 9, 2022 13:55
@lchrusciel lchrusciel merged commit 03cd14f into Sylius:1.11 Feb 9, 2022
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the catalog-promotions-states-fixtures branch February 10, 2022 05:36
@lchrusciel lchrusciel mentioned this pull request Feb 10, 2022
Merged
GSadee added a commit that referenced this pull request Feb 10, 2022
@GSadee
minor #13635 [Docs] Drop warning about active, not applied promotions…
88ed626 
… as states are handled in async manner as well (lchrusciel)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Reverts #13630  because of #13624
| License         | MIT

This case does not exists anymore, as states are processed async as well 

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

1318c11 [Docs] Drop warning about active, not applied promotions as states are handled in async manner as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GSadee @lchrusciel @AdamKasp