[ADR] Declaring services as public in container #13641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Feb 11, 2022
lchrusciel
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
added
the
Documentation
probot-autolabeler
bot
added
the
Maintenance
Zales0123
reviewed
Feb 11, 2022
lchrusciel
force-pushed
the
adr-public-services
branch
3 times, most recently
from
e4313d3
to
4e9ad36
Compare
|
What about performances? Isn't it heavier to have all services public? |
|
According to Mateusz posts(#13641 (comment)) we already have 964 services, all of them(or at least majority) are public. So creation of new private services probably have neglectable influence over the website. |
lchrusciel
force-pushed
the
adr-public-services
branch
from
4e9ad36
to
2811f19
Compare
Zales0123
approved these changes
Feb 14, 2022
GSadee
approved these changes
Feb 14, 2022
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
GSadee
force-pushed
the
adr-public-services
branch
from
2811f19
to
6a4313d
Compare
lchrusciel
force-pushed
the
adr-public-services
branch
from
6a4313d
to
6adb39d
Compare
|
Thanks, Łukasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.