Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Cancel unpaid orders command #13660

Merged
merged 15 commits into from
Feb 22, 2022
Merged

[CLI] Cancel unpaid orders command #13660

merged 15 commits into from
Feb 22, 2022

Conversation

rafalswierczek
Copy link

@rafalswierczek rafalswierczek commented Feb 17, 2022 •
edited
Loading

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #13442
License MIT

@rafalswierczek rafalswierczek requested a review from a team as a code owner February 17, 2022 12:01
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 17, 2022
@rafalswierczek rafalswierczek changed the base branch from master to 1.11 February 17, 2022 12:01
Zales0123
Zales0123 reviewed Feb 17, 2022
View reviewed changes
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php Outdated Show resolved Hide resolved
@rafalswierczek rafalswierczek changed the title [CLI] Cancel unpaid orders command [WIP] [CLI] Cancel unpaid orders command Feb 17, 2022
@AdamKasp
Copy link
Contributor

it looks like a bug fix so IMO it should be opened to sylius 1.10 (we are still fully maintaning it :) )

Zales0123
Zales0123 reviewed Feb 18, 2022
View reviewed changes
src/Sylius/Behat/Context/Domain/ManagingOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/OrderContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/OrderContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/OrderContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/suites.yml Outdated Show resolved Hide resolved
GSadee
GSadee reviewed Feb 18, 2022
View reviewed changes
features/cli/cancel_unpaid_orders.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Cli/CancelUnpaidOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Domain/ManagingOrdersContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/OrderContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/OrderContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/suites.yml Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Doctrine/ORM/OrderRepository.php Show resolved Hide resolved
@rafalswierczek rafalswierczek added Bug Confirmed bugs or bugfixes. and removed Documentation Documentation related issues and PRs - requests, fixes, proposals. labels Feb 18, 2022
@rafalswierczek rafalswierczek changed the title [WIP] [CLI] Cancel unpaid orders command [CLI] Cancel unpaid orders command Feb 18, 2022
@GSadee GSadee changed the base branch from 1.11 to 1.10 February 18, 2022 19:21
@GSadee
Copy link
Member

GSadee commented Feb 18, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "SYL-1835-cancel-unpaid-orders" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee force-pushed the SYL-1835-cancel-unpaid-orders branch from 4ac2ab4 to 04087cd Compare February 18, 2022 19:21
SirDomin
SirDomin reviewed Feb 20, 2022
View reviewed changes
Copy link
Contributor

@SirDomin SirDomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description should be changed to match actual branch (1.11 -> 1.10)

@GSadee GSadee merged commit 0da6306 into Sylius:1.10 Feb 22, 2022
@GSadee
Copy link
Member

GSadee commented Feb 22, 2022

Thanks, Rafał! 🎉

@rafalswierczek rafalswierczek mentioned this pull request Feb 22, 2022
Merged
GSadee added a commit that referenced this pull request Feb 23, 2022
@GSadee
minor #13683 Improve verbosity of canceling unpaid orders test ()
b16613f 
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | mentioned in [#Z](#13660)
| License         | MIT



Commits
-------

e4397a0 Improve verbosity of canceling unpaid orders test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@SirDomin SirDomin SirDomin left review comments

@AdamKasp AdamKasp AdamKasp left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel unpaid orders command should not cancel refunded/partially refunded order
5 participants
@rafalswierczek @AdamKasp @GSadee @Zales0123 @SirDomin