Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Adding a helpful error message to the ResetPasswordHandler #13661

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Feb 17, 2022

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Before:

Uncaught PHP Exception Webmozart\Assert\InvalidArgumentException: "Expected a value other than null." at /var/www/sylius/vendor/webmozart/assert/src/Assert.php line 2060

After:

Uncaught PHP Exception Webmozart\Assert\InvalidArgumentException: "No user found with reset token: <TOKEN>" at /var/www/sylius/vendor/webmozart/assert/src/Assert.php line 2060

Maybe we also should have a check in the codestyle that finds all other occurrences, where a error message is missing.

@mamazu mamazu requested a review from a team as a code owner February 17, 2022 12:46
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Feb 17, 2022
@AdamKasp AdamKasp added the DX Issues and PRs aimed at improving Developer eXperience. label Feb 21, 2022
@SirDomin SirDomin merged commit 6c5cb47 into Sylius:master Feb 21, 2022
@SirDomin
Copy link
Contributor

Thank you, @mamazu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants