[Cart] Fix retrieving/overriding cart of logged in user by guest #13676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Feb 22, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | replaces #13603 and #13634 |
| License | MIT |
probot-autolabeler
bot
added
Maintenance
GSadee
force-pushed
the
fix-retrieving-cart-by-guest
branch
from
5fd2b8e
to
e77183b
Compare
AdamKasp
reviewed
Feb 22, 2022
src/Sylius/Bundle/CoreBundle/Migrations/Version20220210135918.php
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Feb 22, 2022
src/Sylius/Component/Core/Cart/Context/ShopBasedCartContext.php
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
fix-retrieving-cart-by-guest
branch
2 times, most recently
from
bf8f3ee
to
caa7298
Compare
AdamKasp
approved these changes
Feb 22, 2022
Zales0123
approved these changes
Feb 23, 2022
stloyd
reviewed
Feb 23, 2022
src/Sylius/Component/Core/Cart/Resolver/ByGuestFlagResolver.php
Outdated
Show resolved
Hide resolved
…ser after login/registration
GSadee
force-pushed
the
fix-retrieving-cart-by-guest
branch
from
caa7298
to
ff3b03a
Compare
lchrusciel
reviewed
Feb 23, 2022
GSadee
force-pushed
the
fix-retrieving-cart-by-guest
branch
from
fb0c912
to
8b0faf3
Compare
GSadee
force-pushed
the
fix-retrieving-cart-by-guest
branch
from
8b0faf3
to
cdd57b1
Compare
SirDomin
approved these changes
Feb 24, 2022
|
Thanks, Grzegorz! 🥇 |
AdamKasp
added a commit
that referenced
this pull request
Feb 24, 2022
…me (GSadee) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13676 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 40b1f5d [Order] Change getters and setters to use a proper flag name
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.