Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Order] Change getters and setters to use a proper flag name #13695

Merged

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Feb 24, 2022

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #13676
License MIT

@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Feb 24, 2022
@GSadee GSadee requested a review from a team as a code owner February 24, 2022 09:58
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Feb 24, 2022
@GSadee GSadee force-pushed the change-getters-and-setters-of-guest-flag branch from 2aa768e to dbcd408 Compare February 24, 2022 10:22
@GSadee GSadee force-pushed the change-getters-and-setters-of-guest-flag branch from dbcd408 to 40b1f5d Compare February 24, 2022 10:43
@AdamKasp AdamKasp merged commit 63e9fd7 into Sylius:1.10 Feb 24, 2022
@AdamKasp
Copy link
Contributor

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the change-getters-and-setters-of-guest-flag branch February 24, 2022 12:11
AdamKasp added a commit that referenced this pull request Feb 25, 2022
…after upmerge issue (GSadee)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | after #13695
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

5a908ff [Order] Fix getters and setters to use a proper flag name after upmerge issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants