[Order] Fix getters and setters to use a proper flag name after upmerge issue #13700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Feb 24, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | after #13695 |
| License | MIT |
Roshyo
reviewed
Feb 25, 2022
| @@ -477,12 +477,12 @@ public function getNonDiscountedItemsTotal(): int | |||
| return $total; | |||
| } | |||
|
|
|||
| public function getByGuest(): bool | |||
| public function getCreatedByGuest(): bool | |||
There was a problem hiding this comment.
Shouldn't it be isCreatedByGuest instead ?
There was a problem hiding this comment.
It probably should... but this is a PR just to fix conflicts after upmerge, we can fix it from 1.10 ⬆️ later on :)
There was a problem hiding this comment.
It could be, it looks probably more natural, but it should be changed on 1.10 branch, as the new field has been introduced there, in this PR I'm only fixing the problem after upmerge branches
AdamKasp
approved these changes
Feb 25, 2022
|
Thanks, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.