[Taxation] Add validation of negative tax rate #13731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coldic3
commented
Mar 7, 2022
•
coldic3
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
coldic3
changed the title
coldic3
changed the title
stloyd
reviewed
Mar 7, 2022
src/Sylius/Bundle/TaxationBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
AdamKasp
reviewed
Mar 7, 2022
src/Sylius/Bundle/TaxationBundle/Resources/translations/validators.pl.yml
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Mar 7, 2022
src/Sylius/Bundle/TaxationBundle/Resources/translations/validators.en.yml
Show resolved
Hide resolved
src/Sylius/Bundle/TaxationBundle/Resources/translations/validators.pl.yml
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
feature/tax-rate-without-negative-amount
branch
from
e868b40
to
64d7919
Compare
GSadee
approved these changes
Mar 7, 2022
features/taxation/managing_tax_rates/tax_rate_validation.feature
Outdated
Show resolved
Hide resolved
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
GSadee
force-pushed
the
feature/tax-rate-without-negative-amount
branch
from
64d7919
to
dc727c5
Compare
SirDomin
approved these changes
Mar 8, 2022
Zales0123
approved these changes
Mar 8, 2022
AdamKasp
approved these changes
Mar 8, 2022
coldic3
force-pushed
the
feature/tax-rate-without-negative-amount
branch
from
2231002
to
92d3561
Compare
Co-authored-by: Adam Kasperczak <adamkasperczak123@gmail.com>
Co-authored-by: Grzegorz Sadowski <sadowskigp@gmail.com>
GSadee
force-pushed
the
feature/tax-rate-without-negative-amount
branch
from
8c6d34d
to
523a4ea
Compare
|
Thank you, Kevin! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Mar 14, 2022
…ic3) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | mentioned in #13731 (comment) | License | MIT As far as "I want to..." statement is a kind of user action the step should be 'When'. Commits ------- 984488d [Behat] Use "When" for user actions where possible
|
Guys, why not use https://symfony.com/doc/current/reference/constraints/PositiveOrZero.html. In many cases 0% is also a perfectly fine tax percentage. This is now no longer possible because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.