Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance]Ignore phpstan.neon file #13744

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Mar 9, 2022

Due to the presence of the phpstan.neon.dist file, I would like to propose adding the phpstan.neon config file to the gitignore as the phpunit, phpspec are ignored.

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
License MIT

@Ferror Ferror requested a review from a team as a code owner March 9, 2022 11:05
@Ferror Ferror changed the title Ignore phpstan.neon file [Maintenance] Ignore phpstan.neon file Mar 9, 2022
@Ferror Ferror self-assigned this Mar 9, 2022
@Zales0123 Zales0123 added the Maintenance CI configurations, READMEs, releases, etc. label Mar 14, 2022
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Shop ShopBundle related issues and PRs. labels Mar 14, 2022
@Ferror Ferror force-pushed the ignore-phpstan-config-file branch from d1730b3 to 0f60fd3 Compare March 14, 2022 13:11
@Ferror Ferror changed the title [Maintenance] Ignore phpstan.neon file [Maintenance]Ignore phpstan.neon file Mar 15, 2022
@lchrusciel lchrusciel changed the base branch from master to 1.10 March 25, 2022 10:17
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "ignore-phpstan-config-file" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Mar 25, 2022
@lchrusciel lchrusciel merged commit 49e527a into Sylius:1.10 Mar 25, 2022
@lchrusciel
Copy link
Member

Thank you, Zbigniew! 🥇

@Ferror Ferror deleted the ignore-phpstan-config-file branch September 14, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants