Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Change PHP ini values + clear cache #13756

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 10, 2022

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

This is another attempt to fix our builds, as they seem to be fixed on 1.11 and master branches, 1.10 is still failing. I change here the ini values of PHP and add clearing cache before some steps in our application workflow to be consistent with 1.11 where it had been changed some time ago.

@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Mar 10, 2022
@GSadee GSadee requested a review from a team as a code owner March 10, 2022 20:06
Copy link
Contributor

@Ferror Ferror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why are we disabling opcache for CLI?

@GSadee
Copy link
Member Author

GSadee commented Mar 10, 2022

But why are we disabling opcache for CLI?

It is a good question 😃, to be honest, I'm not sure if is needed, but after this PR, configs for 1.10 and 1.11 branches will be the same, this is what I wanted to achieve.
I will open another PR to revert the change of opcache for CLI to see the status of build 🕵🏻

@GSadee GSadee merged commit 8f2c00d into Sylius:1.10 Mar 10, 2022
@GSadee GSadee deleted the fix-1.10-build branch March 10, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants