Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Use "When" for user actions where possible #13759

Merged

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Mar 11, 2022

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in #13731 (comment)
License MIT

As far as "I want to..." statement is a kind of user action the step should be 'When'.

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Mar 11, 2022
@coldic3 coldic3 changed the title [Behat] Use "When" for user actions where possible [WIP][Behat] Use "When" for user actions where possible Mar 11, 2022
@coldic3 coldic3 marked this pull request as ready for review March 11, 2022 10:23
@coldic3 coldic3 requested a review from a team as a code owner March 11, 2022 10:23
@coldic3 coldic3 force-pushed the refactor/behat-when-steps-where-possible branch 3 times, most recently from 6cd8354 to 984488d Compare March 11, 2022 11:46
@coldic3 coldic3 changed the title [WIP][Behat] Use "When" for user actions where possible [Behat] Use "When" for user actions where possible Mar 11, 2022
@GSadee GSadee added the Behat Issues and PRs aimed at improving Behat usage. label Mar 14, 2022
@lchrusciel lchrusciel merged commit 7d40d80 into Sylius:1.10 Mar 14, 2022
@lchrusciel
Copy link
Member

Thank you, Kevin! 🎉

@coldic3 coldic3 deleted the refactor/behat-when-steps-where-possible branch March 14, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Behat Issues and PRs aimed at improving Behat usage. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants