Change sylius.behat.context.ui.email context to sylius.behat.context.api.email #13767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferror
changed the title
|
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
GSadee
force-pushed
the
bugfix-or-feature
branch
from
7b1a619
to
0ab3231
Compare
GSadee
approved these changes
Mar 30, 2022
Roshyo
approved these changes
Apr 6, 2022
|
There were some steps missing in API Context, so when #13829 PR will be merged the pipelines will be green :) |
Ferror
force-pushed
the
bugfix-or-feature
branch
from
fccd9b2
to
db02e8c
Compare
Ferror
force-pushed
the
bugfix-or-feature
branch
from
47d1260
to
5581210
Compare
Ferror
commented
Apr 7, 2022
| @@ -263,7 +263,6 @@ | |||
| <argument type="service" id="sylius.behat.current_page_resolver" /> | |||
| <argument type="service" id="sylius.behat.notification_checker" /> | |||
| <argument type="service" id="sylius.behat.java_script_test_helper" /> | |||
| <argument type="service" id="behat.mink.default_session" /> | |||
There was a problem hiding this comment.
ManagingTaxonsContext has only 7 arguments ;p
GSadee
approved these changes
Apr 8, 2022
|
Thank you, Zbigniew! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, but the API resources had
sylius.behat.context.ui.emailsuites defined, not sure whether they are misconfiguration or feature. Could not find reason for it in the PRs.