[Core][Shipping] Fix estimated shipping costs #13769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coldic3
commented
Mar 15, 2022
coldic3
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #12554, #13123, related to #13126 |
| License | MIT |
coldic3
added
Shop
coldic3
force-pushed
the
fix/estimated-shipping-cost
branch
from
786c7e6
to
e3e3bb7
Compare
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
reviewed
Mar 15, 2022
.../applying_shipping_method_rules/seeing_estimated_shipping_cost_based_on_total_weight.feature
Outdated
Show resolved
Hide resolved
.../applying_shipping_method_rules/seeing_estimated_shipping_cost_based_on_total_weight.feature
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Mar 15, 2022
coldic3
force-pushed
the
fix/estimated-shipping-cost
branch
from
eb837d6
to
2c3d6ed
Compare
coldic3
force-pushed
the
fix/estimated-shipping-cost
branch
from
2c3d6ed
to
6543f28
Compare
coldic3
commented
Mar 16, 2022
src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
coldic3
changed the title
AdamKasp
approved these changes
Mar 16, 2022
...g/applying_shipping_method_rules/seeing_estimated_shipping_cost_based_on_order_total.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreConfigurationTest.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreExtensionTest.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/estimated-shipping-cost
branch
from
6543f28
to
3333d07
Compare
lchrusciel
reviewed
Mar 16, 2022
src/Sylius/Bundle/CoreBundle/Tests/DependencyInjection/SyliusCoreConfigurationTest.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Mar 16, 2022
src/Sylius/Bundle/CoreBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/estimated-shipping-cost
branch
from
a8083db
to
d790944
Compare
lchrusciel
approved these changes
Mar 17, 2022
| { | ||
| $this->expectException(InvalidTypeException::class); | ||
|
|
||
| (new PartialProcessor())->processConfiguration( |
There was a problem hiding this comment.
The exception message is different depending on the Symfony version. I was looking for a solution to just throw this error by setting an invalid configuration and then check if the exception class is the same.
GSadee
approved these changes
Mar 18, 2022
|
Thanks, Kevin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Mar 25, 2022
…ecalculating prices (coldic3) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Related tickets | #13769 | License | MIT Commits ------- 7b2ad4f [Core][Shipping] Deprecate processing shipments before recalculating prices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.