Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locale] Change language negotiation to RFC 4647 based #13777

Merged
merged 4 commits into from Dec 22, 2023
Merged

[Locale] Change language negotiation to RFC 4647 based #13777

merged 4 commits into from Dec 22, 2023

Conversation

gseric
Copy link
Contributor

@gseric gseric commented Mar 16, 2022 •
edited

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Following this PR: #13708

@gseric gseric requested a review from a team as a code owner March 16, 2022 23:16
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Mar 16, 2022
@lchrusciel
Copy link
Member

Hey Goran,

thanks a lot for your contribution and welcome among our contributors :). I will try to review it ASAP (within two weeks probably).

lchrusciel
lchrusciel reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Goran,

thanks for the PR + pretty nice docs update. You rock. I've added a few review comments

tests/Api/Shop/ProductsTest.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/LocaleBundle/Resources/config/services.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php Outdated Show resolved Hide resolved
Zales0123
Zales0123 reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but we should probably also mention this change in the UPGRADE file

@probot-autolabeler probot-autolabeler bot added Docker Docker-related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Dec 21, 2023
@NoResponseMate NoResponseMate changed the base branch from 1.11 to 1.12 December 21, 2023 17:23
@NoResponseMate NoResponseMate added Bug Confirmed bugs or bugfixes. and removed Maintenance CI configurations, READMEs, releases, etc. Docker Docker-related issues and PRs. labels Dec 21, 2023
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Dec 21, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz merged commit cb7b689 into Sylius:1.12 Dec 22, 2023
27 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @gseric!

@jakubtobiasz
Copy link
Member

and @NoResponseMate too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@lchrusciel lchrusciel lchrusciel left review comments

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees

@NoResponseMate NoResponseMate

Labels
Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gseric @lchrusciel @jakubtobiasz @Zales0123 @NoResponseMate