Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Not render empty value in multi select autocompletes #13805

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

ernestWarwas
Copy link
Contributor

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #13734
License MIT

After we fixed single autocompletes we have create a bug when we can add an empty value in multi-select autocompletes. Now we are not adding this empty value in multi-select.

In single autocompletes:
image
In multi-select autocompletes:
image

@ernestWarwas ernestWarwas added the Bug Confirmed bugs or bugfixes. label Mar 29, 2022
@ernestWarwas ernestWarwas requested a review from a team as a code owner March 29, 2022 10:37
@ernestWarwas ernestWarwas changed the base branch from master to 1.10 March 29, 2022 10:37
@GSadee GSadee merged commit d914e59 into Sylius:1.10 Mar 30, 2022
@GSadee
Copy link
Member

GSadee commented Mar 30, 2022

Thanks, Ernest! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants