[Admin] Clean up and refactor new template events #13817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Apr 1, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.10 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | after #13798, replaces #13815 |
| License | MIT |
GSadee
added
DX
SirDomin
approved these changes
Apr 1, 2022
Jibbarth
added a commit
to Jibbarth/SyliusPayPalPlugin
that referenced
this pull request
May 5, 2023
…ayment This follow up Sylius/Sylius#13817
Jibbarth
added a commit
to Jibbarth/SyliusPayPalPlugin
that referenced
this pull request
May 5, 2023
…ayment This follow up Sylius/Sylius#13817
Jibbarth
added a commit
to Jibbarth/SyliusPayPalPlugin
that referenced
this pull request
Oct 2, 2023
…ayment This follow up Sylius/Sylius#13817
GSadee
added a commit
to Sylius/PayPalPlugin
that referenced
this pull request
Oct 6, 2023
…n Order Show payment (Jibbarth) This PR was merged into the 1.5 branch. Discussion ---------- This follow up Sylius/Sylius#13817 | Q | A | --------------- | ----- | Branch? | 1.5 (bug fixes, improvements) | Bug fix? | no/yes | New feature? | no/yes | Related tickets | fixes #X, partially #Y, mentioned in #Z This part of the template should be added via Sylius Ui Event, and it will allow to remove this template in Sylius-Standard, to be able to have the refund button removed when installing https://github.com/Sylius/RefundPlugin A PR on sylius standard will follow Commits ------- a58ab1e [UI] Display refunded part as a sylius ui event in Admin Order Show payment 25c604e Use constant for payment state 1cd0fa0 Change pay_pal_refunded_message block priority
GSadee
added a commit
to Sylius/Sylius-Standard
that referenced
this pull request
Apr 15, 2024
… ui event (Jibbarth, GSadee) This PR was merged into the 1.12 branch. Discussion ---------- This follow up Sylius/Sylius#13817 and Sylius/PayPalPlugin#276 I noticed that when installing refund plugin on a 1.12 version, I have both Refund functionnality from plugin and the native button under payment. The refund plugin disable the native button using sylius event, but with this template coming in standard, that has no effect. Let's remove it, and fully embrace the sylius ui event system 🤗 The paypal customization has been backported in paypal plugin ui events. Commits ------- 5af304e [UI] Remove default override of _payment to allow using ui event 185eb48 Bump up PayPalPlugin to the newest patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.