[Maintenance][Docker]Create simple docker environment #13850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
Ferror
changed the title
coldic3
reviewed
Apr 8, 2022
Ferror
force-pushed
the
docker-environment
branch
from
6375485
to
c2bf418
Compare
lchrusciel
reviewed
Apr 12, 2022
Makefile
Outdated
| bin/console sylius:fixtures:load default --no-interaction | ||
| bin/console cache:warmup | ||
| yarn install --pure-lockfile | ||
| node_modules/gulp/bin/gulp.js |
There was a problem hiding this comment.
why aren't you using yarn build command?
There was a problem hiding this comment.
I mean for sake of readability I can change that. But the reason for that.. they are the same commands. When running gulp without any command parameter he will run the export default from gulpfile.js which in our case is build.
Long story short in our case node_modules/gulp/bin/gulp.js and yarn build are the same.
Ferror
force-pushed
the
docker-environment
branch
from
c2bf418
to
35b883b
Compare
Ferror
force-pushed
the
docker-environment
branch
from
eec8ab2
to
49589a8
Compare
|
@lchrusciel can I ask you for merge or re-review? |
lchrusciel
approved these changes
Apr 21, 2022
Comment on lines
+15
to
+17
| vendor/bin/phpunit | ||
| vendor/bin/phpspec run --ansi --no-interaction -f dot | ||
| vendor/bin/behat --colors --strict --no-interaction -vvv -f progress --tags="~@javascript&&@cli&&~@todo" # CLI Behat |
There was a problem hiding this comment.
Thought for later - won't it be better to reference this file instead of duplication of logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of working Sylius monorepo Docker Compose. Please note, that it is a simple docker environment and some things may not work yet out of the box - we should use it and inform you about any existing issues.
Things that do not work yet, but are not crucial
xdebugyet, but it will be provided in the nearest futureRequirements
How to run?
docker compose up -ddocker-compose exec app bashordocker compose exec app bashfor docker compose V2make init- it will execute fixtures and composerhttp://localhost:80How to update?
docker-compose downdocker compose up -dmake init- it will execute fixtures, composer, and node updateshttp://localhost:80