[Maintenance] Run the build on tags rather than on releases #13852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Apr 13, 2022
| @@ -2,6 +2,8 @@ name: Application | |||
|
|
|||
| on: | |||
| push: | |||
| tags: | |||
| - v1.* | |||
There was a problem hiding this comment.
Why did you decide to run them only on 1.x?
GSadee
approved these changes
Apr 14, 2022
GSadee
reviewed
Apr 14, 2022
| @@ -2,6 +2,8 @@ name: Application | |||
|
|
|||
| on: | |||
| push: | |||
| tags: | |||
| - v1.* | |||
There was a problem hiding this comment.
Suggested change
| - v1.* | |
| - v* |
or
Suggested change
| - v1.* | |
| - * |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag push is an actual moment when the new version of Sylius is done, the release is just the icing on the cake 馃嵃 So it makes more sense to run the workflow when the real thing is happening, not when it's nicely served 馃枛