Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat][API] Extract resources names from contexts to a separate class #13869

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Apr 14, 2022

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets after #13832
License MIT

To avoid potential problems with defining resources names using API client, I've extracted available resources to one class in Behat.

@GSadee GSadee added Behat Issues and PRs aimed at improving Behat usage. API APIs related issues and PRs. labels Apr 14, 2022
@GSadee GSadee requested a review from a team as a code owner April 14, 2022 05:33
@lchrusciel lchrusciel merged commit 98d1141 into Sylius:master Apr 14, 2022
@lchrusciel
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the behat-api-resources-enum branch April 14, 2022 10:06
GSadee added a commit that referenced this pull request Oct 10, 2022
…Milek)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.12 <!-- see the comment below -->                  |
| Bug fix?        | no                                                     |
| New feature?    | no                                                     |
| BC breaks?      | no                                                   |
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.11 branch
 - Features and deprecations must be submitted against the 1.12 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Related to [PR](#13832) and [PR](#13869) 

Commits
-------

3610c30 [API][Behat] Add note about behat client changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants