Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Template] Variant name instead of product name #13878

Merged
merged 2 commits into from
Apr 14, 2022
Merged

[Template] Variant name instead of product name #13878

merged 2 commits into from
Apr 14, 2022

Conversation

ernestWarwas
Copy link
Contributor

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Show variant name instead of the product name.

@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Apr 14, 2022
@ernestWarwas ernestWarwas marked this pull request as ready for review April 14, 2022 14:15
@ernestWarwas ernestWarwas requested a review from a team as a code owner April 14, 2022 14:15
Ferror
Ferror approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@Ferror Ferror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Ferror
Ferror reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@Ferror Ferror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. We have tons of tests and we don't have a scenario to check if the variant name is actually the variant name?

Maybe we could provide a scenario like this in the next iteration? Even in sprint :)

@ernestWarwas
Copy link
Contributor Author

Btw. We have tons of tests and we don't have a scenario to check if the variant name is actually the variant name?

We have tests for that 😄 I didn't check it. Fixed.

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Apr 14, 2022
@lchrusciel lchrusciel merged commit 07e1d4e into Sylius:1.10 Apr 14, 2022
@lchrusciel
Copy link
Member

Thank you, Ernest! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferror Ferror Ferror approved these changes

@GSadee GSadee GSadee approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ernestWarwas @lchrusciel @GSadee @Ferror