[HotFix][Behat][API] Fix suddenly failing tests #13879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
fix/viewing-products-behat-tests
branch
from
c1f4638
to
836ed3b
Compare
GSadee
approved these changes
Apr 15, 2022
AdamKasp
approved these changes
Apr 15, 2022
lchrusciel
reviewed
Apr 15, 2022
There was a problem hiding this comment.
It appears to me to be quite a smell in the design. If we are "resending" something, that is stateful within the object, because the returned value was overridden. To fix this issue, I would recommend sending a proper request before making checks and in another round removal of the statefulness of clients at all
lchrusciel
changed the title
lchrusciel
added
API
|
Thank you, Kevin! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there is a need to resend a request if the last response has been overwritten.