Use api route prefix parameter instead of /api/v2
#13881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometee
changed the title
/api/v2/api/v2
lchrusciel
approved these changes
Apr 25, 2022
lchrusciel
reviewed
Apr 25, 2022
| @@ -45,17 +38,18 @@ public function normalize($object, $format = null, array $context = []) | |||
| $enums = $this->filterProvider->provideShopFilters(); | |||
| $enums = array_keys($enums); | |||
|
|
|||
| $params = $docs['paths'][self::SHOP_ITEM_PATH]['get']['parameters']; | |||
| $shopProductImagePath = $this->apiRoute . '/shop/product-images/{id}'; | |||
There was a problem hiding this comment.
I would leave suffix as a const
There was a problem hiding this comment.
I also think of it but it was a private const so it wasn't editable nor accessible.
lchrusciel
added
Enhancement
|
Thanks, Francis! 🎉 |
|
@lchrusciel I'm also thinking about doing this kind of api route prefix for the Behat tests, because it forces us to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to be able to use another api route prefix while generating the swagger page.