[Admin][Cart Promotions] Coupons based - generate coupons - error message not showing the correct limit.

[petrjuraseko]

Sylius version affected: 1.11.3

Description
Generate cart promo actions with coupons based
Generate coupons enter Code length with number 1024.
I see error message:

Coupon code must not be longer than {{ limit }} characters.

The limit is not specified. Not sure what the limit is.

Steps to reproduce
Generate cart promo actions with coupons based
Generate coupons enter Code length with number 1024.

Possible Solution
Correct the translation limit.

[ernestWarwas]

Hi @petrjuraseko, could you provide us a working behat scenario for that like features/promotion/managing_coupons/coupon_generate_validation.feature 🚀

[diimpp]

While I do not reproduce your issue at fresh 1.12 installation,

I'm getting symfony default This value should be between {{ min }} and {{ max }}. message instead of min,max messages.

Reason for that is Range constraint, which introduced new notInRangeMessage option at 4.4, which supersedes min,max messages, if both min and max values defined.

There are several affected validation rules in the project.

Sylius/src/Sylius/Bundle/PromotionBundle/Resources/config/validation/PromotionCouponGeneratorInstruction.xml

Line 33 in 9506c80

<constraint name="Range">

Sylius/src/Sylius/Bundle/PromotionBundle/Form/Type/Action/UnitPercentageDiscountConfigurationType.php

Line 35 in 9506c80

new Range([

Sylius/src/Sylius/Bundle/ApiBundle/Resources/config/validation/AddProductReview.xml

Line 23 in 9506c80

<constraint name="Range">

I'll work on PR tomorrow.