Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker]Run Catalog Promotion via SYNC messenger transport #13897

Merged
merged 4 commits into from
Apr 29, 2022
Merged

[docker]Run Catalog Promotion via SYNC messenger transport #13897

merged 4 commits into from
Apr 29, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Apr 26, 2022

Q A
Branch? 1.10, 1.11 or master
Bug fix? no/yes
New feature? no/yes
BC breaks? no/yes
Deprecations? no/yes
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Apr 26, 2022
@Ferror Ferror marked this pull request as ready for review April 28, 2022 11:21
@Ferror Ferror requested a review from a team as a code owner April 28, 2022 11:21
@lchrusciel lchrusciel added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Docker Docker-related issues and PRs. labels Apr 29, 2022
@lchrusciel lchrusciel merged commit e34578a into Sylius:master Apr 29, 2022
@lchrusciel lchrusciel mentioned this pull request Apr 29, 2022
Merged
lchrusciel added a commit that referenced this pull request Apr 29, 2022
@lchrusciel
minor #13914 Revert "[docker]Run Catalog Promotion via SYNC messenger…
4b907c6 
… transport" (lchrusciel)

This PR was merged into the 1.12-dev branch.

Discussion
----------

Reverts #13897, due to too quick merge. The build itself was red and it should not land in the codebase in the first place

Commits
-------

3f0750b Revert "[docker]Run Catalog Promotion via SYNC messenger transport"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Docker Docker-related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ferror @lchrusciel