Support Twig 3 #13912
Merged
Support Twig 3 #13912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Apr 29, 2022
Zales0123
force-pushed
the
support-twig-3.0
branch
from
9fd6674
to
6792c7a
Compare
GSadee
approved these changes
May 4, 2022
|
Thanks, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering, is it worth running builds on both Twig 2 and 3 🤔 But we already have a lot of them, so I decided to skip it for now. Maybe we should have one additional build with Twig 2 (as with the current
composer updatewe will always use Twig 3)? 🤷♂️ Nevertheless, it's nice we can finally support Twig 3 🖖