[API][Behat] Cover scenarios for applying correct taxes

[GSadee]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets
License	MIT

[TheMilek]

Suggested change

	When I change product "PHP T-Shirt" quantity to 1 in my cart
	When I change the number of "PHP T-Shirt" products in the cart to 1

I know we have to clarify, that we are mentioning quantity here, but still what do you think?

[GSadee]

I'm not convinced as we are using quantity keyword both in API and UI for the number of products in the cart, and also in Behat scenarios, so it is clear enough IMO 😃

[lchrusciel]

We could reduce one "if" statement :P

Suggested change

	if (null !== $defaultAddress) {
	$clonedAddress = clone $defaultAddress;
	$clonedAddress->setCustomer(null);
	}
	return $clonedAddress ?? null;
	$clonedAddress = null;
	if (null !== $defaultAddress) {
	$clonedAddress = clone $defaultAddress;
	$clonedAddress->setCustomer(null);
	}
	return $clonedAddress;

or

Suggested change

	if (null !== $defaultAddress) {
	$clonedAddress = clone $defaultAddress;
	$clonedAddress->setCustomer(null);
	}
	return $clonedAddress ?? null;
	if (null !== $defaultAddress) {
	$clonedAddress = clone $defaultAddress;
	$clonedAddress->setCustomer(null);
	return $clonedAddress;
	}
	return null;

[lchrusciel]

that's funny, that this works, as we are cloning it :P

Anyway, we should cover the null case well

[lchrusciel]

Thanks, Grzegorz! 🥇