[API][Shop] Viewing exchange rates #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
feature/exchange-rates-shop-api
branch
from
320ea85
to
2f128cc
Compare
GSadee
reviewed
May 19, 2022
...ures/currency/viewing_exchange_rates/viewing_exchange_rates_based_on_current_channel.feature
Outdated
Show resolved
Hide resolved
...ylius/Bundle/ApiBundle/Doctrine/QueryCollectionExtension/ExchangeRateCollectionExtension.php
Outdated
Show resolved
Hide resolved
coldic3
force-pushed
the
feature/exchange-rates-shop-api
branch
from
2f128cc
to
efa95f5
Compare
coldic3
force-pushed
the
feature/exchange-rates-shop-api
branch
from
efa95f5
to
9de37cb
Compare
GSadee
approved these changes
May 19, 2022
| I want to see all available for me exchange rates | ||
|
|
||
| Background: | ||
| Given the store operates on a channel named "Web-US" with hostname "example.us" |
There was a problem hiding this comment.
Could you explicitly define the base currency here?
|
Thank you, Kevin! 🎉 |
GSadee
added a commit
that referenced
this pull request
May 20, 2022
…ng exchange rates scenario (coldic3) This PR was merged into the 1.12-dev branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | master | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | #13997 (comment) | | License | MIT | Commits ------- 0e70708 [Behat] Explicitly define channel base currency in viewing exchange rates scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces two GET methods for exchange rates.
