Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifications should be final #14004

Merged
merged 2 commits into from
May 27, 2022
Merged

Specifications should be final #14004

merged 2 commits into from
May 27, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented May 18, 2022

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner May 18, 2022 15:31
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels May 18, 2022
@loic425
Copy link
Member Author

loic425 commented May 19, 2022

@Zales0123 @lchrusciel I am suprised that the check is skipped.
Is this due to this line?
https://github.com/Sylius/Sylius/blob/master/.github/workflows/application.yml#L176

@lchrusciel
Copy link
Member

@loic425 what do you mean? It seems that we are running them correctly

@lchrusciel lchrusciel merged commit e3c6986 into Sylius:1.11 May 27, 2022
@lchrusciel lchrusciel added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label May 27, 2022
@loic425 loic425 deleted the maintenance/specifications-should-be-final branch May 27, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loic425 @lchrusciel