Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix github link on search doc #14024

Merged
merged 1 commit into from
May 29, 2022
Merged

[DOCS] Fix github link on search doc #14024

merged 1 commit into from
May 29, 2022

Conversation

arti0090
Copy link
Contributor

Q A
Branch? 1.10
License MIT

Should be tested after the merge as on dev it is different.

@arti0090 arti0090 requested a review from a team as a code owner May 28, 2022 09:44
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label May 28, 2022
@lchrusciel lchrusciel changed the base branch from 1.10 to 1.11 May 29, 2022 16:41
@lchrusciel lchrusciel merged commit d8b4ee7 into Sylius:1.11 May 29, 2022
CoderMaggie
CoderMaggie reviewed May 30, 2022
View reviewed changes
docs/_themes/sylius_rtd_theme/breadcrumbs.html
<a href="https://github.com/{{ github_user }}/{{ github_repo }}/blob/{{ github_version }}{{ conf_py_path }}{{ pagename }}{{ source_suffix }}"
class="fa fa-github"> Edit on GitHub</a>
{% if sourcename == null %}
<a href="https://github.com/{{ github_user }}/{{ github_repo }}/blob/docs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should redirect to this link always, I guess:
https://github.com/Sylius/Sylius/tree/master/docs

Unfortunately, it doesn't work right :<

@arti0090 arti0090 mentioned this pull request May 30, 2022
Merged
GSadee added a commit that referenced this pull request May 31, 2022
@GSadee
bug #14031 [DOCS] Change the github link on search page (arti0090)
e083ab0 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11   |
| License         | MIT                                                          |

Continuation of #14024


Commits
-------

0e06a83 [DOCS] Change the github link on search page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arti0090 @lchrusciel @CoderMaggie