Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Remove section about CurrencyProvider that does not exist #14033

Merged
merged 1 commit into from
May 30, 2022
Merged

[Documentation] Remove section about CurrencyProvider that does not exist #14033

merged 1 commit into from
May 30, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented May 30, 2022

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

The mentioned CurrencyProvider does not exist since 16c50a9 from 2017 🎉

@GSadee GSadee added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label May 30, 2022
@GSadee GSadee requested a review from a team as a code owner May 30, 2022 08:18
CoderMaggie
CoderMaggie reviewed May 30, 2022
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, it would be better to document how to get the available currencies from the channel context instead of just removing the whole section.

@lchrusciel lchrusciel merged commit e4af5da into Sylius:1.11 May 30, 2022
@GSadee GSadee deleted the docs-remove-currency-provider-section branch May 30, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GSadee @lchrusciel @CoderMaggie