Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Introduce PHP 8.0 syntax #14039

Merged
merged 3 commits into from
Jun 24, 2022
Merged

[Behat] Introduce PHP 8.0 syntax #14039

merged 3 commits into from
Jun 24, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented May 31, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets based on #14038, continuation of #13502
License MIT

I've included here also the PR as it has been removed only from master, and now it was making the build failed on this PR

@GSadee GSadee added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. Behat Issues and PRs aimed at improving Behat usage. labels May 31, 2022
@GSadee GSadee requested a review from a team as a code owner May 31, 2022 11:36
@GSadee GSadee changed the title [Behat] Introduce PHP 8.0 syntax [WIP][Behat] Introduce PHP 8.0 syntax May 31, 2022
@GSadee GSadee changed the title [WIP][Behat] Introduce PHP 8.0 syntax [Behat] Introduce PHP 8.0 syntax Jun 1, 2022
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 1, 2022
@Zales0123 Zales0123 force-pushed the behat-php-8.0-syntax branch 3 times, most recently from ac79b23 to 4532fe9 Compare June 24, 2022 08:36
@Zales0123 Zales0123 merged commit 6a8629e into Sylius:1.11 Jun 24, 2022
@Zales0123
Copy link
Member

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the behat-php-8.0-syntax branch June 24, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GSadee @Zales0123