[Addressing] Prevent deleting zones and provinces that are zone members #14041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
fix/prevent-deleting-zones-and-provinces-that-are-zone-members
branch
from
409d8b8
to
cc2f3d6
Compare
coldic3
force-pushed
the
fix/prevent-deleting-zones-and-provinces-that-are-zone-members
branch
3 times, most recently
from
607c45e
to
610832e
Compare
coldic3
changed the title
Ferror
reviewed
Jun 3, 2022
| { | ||
| Assert::contains( | ||
| $this->responseChecker->getError($this->client->getLastResponse()), | ||
| 'Cannot delete, the province is in use.' |
There was a problem hiding this comment.
This error message and Error Cannot delete, the province is in use. src/Sylius/Behat/Context/Ui/Admin/ManagingCountriesContext.php:284 shouldn't be more likely the same?
There was a problem hiding this comment.
"Error" before the error message is something that exists only in flash messages as a message header.
I think it's a good idea to compare just a message in the UI context but I would be for doing it in separate PR as it requires changes in many behat contexts.
GSadee
reviewed
Jun 6, 2022
features/addressing/managing_countries/managing_provinces_of_country.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/Resources/config/services/checkers.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AddressingBundle/EventListener/ZoneMemberIntegrityListener.php
Show resolved
Hide resolved
AdamKasp
reviewed
Jun 6, 2022
features/addressing/managing_countries/managing_provinces_of_country.feature
Show resolved
Hide resolved
coldic3
force-pushed
the
fix/prevent-deleting-zones-and-provinces-that-are-zone-members
branch
from
610832e
to
199f7d5
Compare
…at are zone members
…ing zones and provinces
coldic3
force-pushed
the
fix/prevent-deleting-zones-and-provinces-that-are-zone-members
branch
from
199f7d5
to
1e650c9
Compare
GSadee
approved these changes
Jun 6, 2022
|
Thank you, Kevin! 🥇 |
coldic3
deleted the
fix/prevent-deleting-zones-and-provinces-that-are-zone-members
branch
GSadee
added a commit
that referenced
this pull request
Jun 8, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | #14041 | | License | MIT | Without orphan removal, even if we delete the zone member, the corresponding province/country cannot be removed because orphans still exist in the database. Commits ------- 47fef6e [Addressing] Enable orphan removal for zone members
GSadee
added a commit
that referenced
this pull request
Jun 8, 2022
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.11 | | Bug fix? | yes (for Symfony 6) | | New feature? | no | | BC breaks? | not yet | | Deprecations? | no | | Related tickets | partially #13274 related #14041 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 46cbdef Fix zone member integrity listener 138b136 Keep session for now 561867a Fix Psalm errors 9ab8098 Trying to fix Phpspec on Symfony 4.4 af47339 Fix Phpspec errors again 9ade6f2 Apply suggestions from code review c165241 Use request stack service everytimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to delete the resource (zone or province) that is already in use as a zone member. When we delete such a resource, we cannot access the zone edit screen (and probably even more) because we try to load an unexisting resource 💥
Sample error: